-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make encoding user groups in access tokens configurable #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishank011
force-pushed
the
jwt-token-reduce-size
branch
from
September 20, 2021 15:49
3dcbb3f
to
bfe1d61
Compare
ishank011
changed the title
Don't encode user groups in JWT tokens
Make encoding user groups in access tokens configurable
Sep 20, 2021
ishank011
force-pushed
the
jwt-token-reduce-size
branch
from
September 20, 2021 16:18
edfaef0
to
dfc453f
Compare
Size of token for user einstein (member of three groups):
|
glpatcern
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, as far as I can understand. Hopefully we'll see the immediate benefit with the token provided to WOPI :)
Merging, since all the changes are controlled by a flag so we've ensured it doesn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shared config parameter
skip_user_groups_in_token
which can be used to control whether user groups should be encoded in the reva access tokens or not. If these are skipped, these are retrieved from theuserprovider
service and cached in the authentication interceptors, where these tokens are dismantled.Closes #2084