-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement listing favorites via the dav report API #2071
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
6dda83f
to
ed91069
Compare
@butonic, could you have a look at this approach? I think we still need some system to notify the several services about certain events like file created, file deleted, etc. Apart from that is that the expected approach? Do we still need to list all file from the storage provider and filter them for the favorite flag? |
41821f1
to
2ede95f
Compare
I added filter-files to the dav REPORT API. This enables the listing of favorites.
2ede95f
to
bf36777
Compare
@C0rby @butonic However, this needs to be revisited. Either adding a cache or store this info in the web client and the web client will add the fav icon where needed by matching fileids from the webdav response. |
@butonic @C0rby I've reverted this PR. I didn't realize of the hack of using the direct fs in the ocdav layer that bypass all the grpc logic, plus it breaks any deployment just by running it with another driver. Please remove the dependency on the |
Right, I'll change the implementation to make the calls via GRPC and then we'll solve the potential performance problem later on. |
This reverts commit df33e69.
I added filter-files to the dav REPORT API. This enables the listing of
favorites.
This PR also includes a new in-memory
storage.FS
implementation which I use for the unit tests of the favorite package but it can also be extended and used for other unit tests depending on a storage.