Extend AppRegistry and AppProvider #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
force-pushed
the
appreg-mimetypes
branch
9 times, most recently
from
3f94e84 to
a858fb2
Compare
glpatcern
force-pushed
the
appreg-mimetypes
branch
4 times, most recently
from
61bff26 to
ead121a
Compare
glpatcern
force-pushed
the
appreg-mimetypes
branch
4 times, most recently
from
0838452 to
bfb2969
Compare
glpatcern
force-pushed
the
appreg-mimetypes
branch
5 times, most recently
from
3fddae5 to
076c5bc
Compare
|
@ishank011 this is now (finally) complete. I will test it tomorrow in our QA before giving you green light for merging (can't validate the tests yet as we need to merge the CS3APIs PR first), but it can already be reviewed. |
glpatcern
force-pushed
the
appreg-mimetypes
branch
from
b49d0d2 to
8cb06fe
Compare
|
Merged cs3org/cs3apis#145 |
glpatcern
force-pushed
the
appreg-mimetypes
branch
2 times, most recently
from
e30836f to
3b2879b
Compare
ishank011
reviewed
Sep 23, 2021
ishank011
reviewed
Sep 23, 2021
glpatcern
force-pushed
the
appreg-mimetypes
branch
from
bd5cef8 to
e066574
Compare
gmgigi96
reviewed
Sep 23, 2021
glpatcern
force-pushed
the
appreg-mimetypes
branch
2 times, most recently
from
ceb8dfa to
bfaf26d
Compare
glpatcern
force-pushed
the
appreg-mimetypes
branch
2 times, most recently
from
fc5d6df to
3beafc3
Compare
This includes the GRPC gateway, the appprovider and its drivers
glpatcern
force-pushed
the
appreg-mimetypes
branch
from
3beafc3 to
879c8bc
Compare
glpatcern
force-pushed
the
appreg-mimetypes
branch
from
879c8bc to
b71f82c
Compare
ishank011
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation in Reva of the extensions in cs3org/cs3apis#145.
Some values have to be filled in from config, this will be targeted in a separate PR.