Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appprovider fixes #2024

Merged
merged 5 commits into from
Sep 1, 2021
Merged

appprovider fixes #2024

merged 5 commits into from
Sep 1, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Aug 31, 2021

applicable after #1968 is merged

@update-docs
Copy link

update-docs bot commented Aug 31, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@labkode
Copy link
Member

labkode commented Aug 31, 2021

@wkloucek some tests with the app provider are failing

@labkode
Copy link
Member

labkode commented Sep 1, 2021

@wkloucek all yours !

@glpatcern glpatcern self-requested a review September 1, 2021 08:53
@wkloucek wkloucek marked this pull request as ready for review September 1, 2021 09:04
@wkloucek wkloucek requested a review from labkode as a code owner September 1, 2021 09:04
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks all good to me following the previous comments

@labkode labkode merged commit b54f42d into cs3org:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants