Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userprovider owncloudsql #1994

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Aug 13, 2021

I am currently using glauth and the graphapi app to use my owncloud10 instance as a user provider for ocis using the ldap user provider ... while that works, it adds significant lag, to a point where listing shares takes ages when a lot of user have to be fetched by claim.

So, I sat down and implemented a small owncloudsql user provider. It works ok, and way faster then my current setup.

We added a new backend for the userprovider that is backed by an owncloud 10 database. By default the user_id column is used as the reva user username and reva user opaque id. When setting join_username=true the reva user username is joined from the oc_preferences table (appid='core' AND configkey='username') instead. When setting join_ownclouduuid=true the reva user opaqueid is joined from the oc_preferences table (appid='core' AND configkey='ownclouduuid') instead. This allows more flexible migration strategies.

@update-docs
Copy link

update-docs bot commented Aug 13, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the userprovider-owncloudsql branch 6 times, most recently from 60994d6 to aa0c036 Compare September 1, 2021 17:10
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic force-pushed the userprovider-owncloudsql branch from aa0c036 to 4940a6e Compare September 1, 2021 17:47
@butonic butonic marked this pull request as ready for review September 1, 2021 18:00
@butonic butonic requested a review from labkode as a code owner September 1, 2021 18:00
@butonic butonic changed the title [WIP] userprovider owncloudsql userprovider owncloudsql Sep 1, 2021
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for writing tests!

pkg/user/manager/owncloudsql/accounts/accounts.go Outdated Show resolved Hide resolved
pkg/user/manager/owncloudsql/owncloudsql.go Outdated Show resolved Hide resolved
pkg/user/manager/owncloudsql/owncloudsql.go Outdated Show resolved Hide resolved
@butonic butonic requested a review from C0rby September 2, 2021 10:09
@labkode labkode merged commit 71a3397 into cs3org:master Sep 3, 2021
@butonic butonic deleted the userprovider-owncloudsql branch September 3, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants