Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references when declining shares #1991

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 13, 2021

Implemented the removal of share references when a share gets declined.
Now when a user declines a share it will no longer be listed in their Shares directory.

@C0rby C0rby force-pushed the remove-reference branch 4 times, most recently from 2dadaba to 8358b4e Compare September 2, 2021 16:37
@C0rby C0rby requested a review from refs September 2, 2021 16:44
@C0rby C0rby marked this pull request as ready for review September 2, 2021 16:44
@C0rby C0rby requested a review from labkode as a code owner September 2, 2021 16:44
@C0rby C0rby self-assigned this Sep 2, 2021
@C0rby C0rby requested a review from butonic September 2, 2021 16:45
butonic
butonic previously approved these changes Sep 3, 2021
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark that I would like clarified before merging, but conceptually 👍 LGTM

refs
refs previously approved these changes Sep 3, 2021
@C0rby C0rby dismissed stale reviews from refs and butonic via 98875bc September 7, 2021 16:30
@C0rby C0rby force-pushed the remove-reference branch 2 times, most recently from 98875bc to 51d1712 Compare September 7, 2021 16:31
@C0rby C0rby requested review from butonic and refs September 7, 2021 16:32
@labkode labkode merged commit 571a960 into cs3org:master Sep 8, 2021
@C0rby C0rby deleted the remove-reference branch September 8, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants