-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement url translation for legacy urls #1989
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This pull request introduces 1 alert when merging 3c1f98c into 756bdce - view on LGTM.com new alerts:
|
3c1f98c
to
c9bbb4d
Compare
This pull request introduces 1 alert when merging c9bbb4d into 011bc08 - view on LGTM.com new alerts:
|
@labkode @butonic, this PR implements the OC10 URL redirect to oCIS. Is the lookup by |
c8f87a2
to
8ac6d09
Compare
This pull request introduces 1 alert when merging 8ac6d09 into 969ac3c - view on LGTM.com new alerts:
|
8ac6d09
to
73c8aee
Compare
This pull request introduces 1 alert when merging 73c8aee into 969ac3c - view on LGTM.com new alerts:
|
To move forward with this I would propose to merge this PR in this state and if necessary implement the fileid based lookup later on. This PR will allow the following:
Also I think the lgtm bot alert can be ignored since this is not an open redirect.
|
73c8aee
to
a8f6ef8
Compare
This pull request introduces 1 alert when merging a8f6ef8 into 969ac3c - view on LGTM.com new alerts:
|
First draft of the URL translation for OC10 URLS.
This implements a redirect from the old OC10 URL format to the current format we use in oCIS web. Currently only the public link and the old files app URL work because we don't do any file lookups by id yet. If this needs to be supported we would need to figure out how to lookup file based on their OC10 id.
To test this you need to apply this diff to oCIS and add a replace for reva to the go.mod file: