Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix value of file_target in shares #1965

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 6, 2021

In some cases the file target of user and group shares was not properly prefixed.

@update-docs
Copy link

update-docs bot commented Aug 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby C0rby force-pushed the fix-share-target branch from e46086e to 50d2f9b Compare August 6, 2021 10:17
@C0rby C0rby requested review from butonic and phil-davis and removed request for butonic August 6, 2021 10:40
@C0rby C0rby marked this pull request as ready for review August 6, 2021 10:40
@C0rby C0rby requested a review from labkode as a code owner August 6, 2021 10:40
@C0rby C0rby requested a review from ishank011 August 6, 2021 10:40
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great win - a big increase in passing scenarios. 🥇

@ishank011 ishank011 merged commit 74545ea into cs3org:master Aug 6, 2021
@C0rby C0rby deleted the fix-share-target branch August 6, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants