Refactor dav #1888
Refactor dav #1888
Conversation
| src := &provider.Reference{Path: srcPath} | ||
| dst := &provider.Reference{Path: dstPath} | ||
|
|
||
| intermediateDirRefFunc := func() (*provider.Reference, *rpc.Status, error) { |
There was a problem hiding this comment.
This looks like an overkill. If you want to modularize this, how about just creating a method that takes a ref and returns a ref having the dir, rather than passing the functor object?
There was a problem hiding this comment.
Yeah it looks overkill but for the spaces the way to get the intermediate directory is different. That is why I'm passing the function so that the caller can decide how to get the intermediate dir.
There was a problem hiding this comment.
I'd still prefer an if condition to determine how to get this intermediate directory but we can discuss it in the spaces PR
| message: m, | ||
| }) | ||
| HandleWebdavError(&sublog, w, b, err) | ||
| cp := s.prepareCopy(ctx, w, r, srcRef, dstRef, intermediateDirRefFunc, &sublog) |
There was a problem hiding this comment.
Can we call prepareCopy from executePathCopy (maybe rename it)?
There was a problem hiding this comment.
Not really, executePathCopy is a recursive function and we would need to introduce some condition to only execute prepareCopy once in executePathCopy.
There was a problem hiding this comment.
Also later there will be a executeSpacesCopy which implements spaces specific stuff, that is why prepareCopy is a function on its own.
I refactored the webdav code to make it cleaner and reusable.
This is a preparation for #1803.
Currently those changes are also in the spaces PR but once this PR is merged we can rebase the spaces PR and reduce its diff.