Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trashbin sub paths in the recycle API #1827

Merged
merged 8 commits into from
Jul 9, 2021
Merged

Support trashbin sub paths in the recycle API #1827

merged 8 commits into from
Jul 9, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jun 25, 2021 •
edited
Loading

  • Implemented depth handling for propfinds
  • Specific files in the trash-bin file tree can be restored
  • Specific files in the trash-bin file tree can be purged

Todo

@update-docs
Copy link

update-docs bot commented Jun 25, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby C0rby force-pushed the implement-trashbin-listing-depth branch from 9e40f2e to 602d1ca Compare June 25, 2021 12:38
@C0rby C0rby changed the title [WIP] implement depth handling for propfinds on the trash-bin [WIP] implement depth handling in the trash-bin API Jun 28, 2021
@C0rby C0rby mentioned this pull request Jun 29, 2021
Merged
@C0rby C0rby force-pushed the implement-trashbin-listing-depth branch 4 times, most recently from 4ce1130 to ef8a0e4 Compare July 2, 2021 14:25
@C0rby C0rby marked this pull request as ready for review July 2, 2021 14:54
@C0rby C0rby requested a review from labkode as a code owner July 2, 2021 14:54
@C0rby C0rby requested review from butonic, ishank011 and refs July 2, 2021 14:54
@C0rby C0rby self-assigned this Jul 2, 2021
@C0rby C0rby changed the title [WIP] implement depth handling in the trash-bin API Implement depth handling in the trash-bin API Jul 2, 2021
@C0rby C0rby changed the title Implement depth handling in the trash-bin API Support trashbin sub paths in the recycle API Jul 2, 2021
@C0rby C0rby force-pushed the implement-trashbin-listing-depth branch from ef8a0e4 to 74312cf Compare July 8, 2021 08:04
@labkode
Copy link
Member

labkode commented Jul 9, 2021

@C0rby a rebase would make it!

@C0rby C0rby force-pushed the implement-trashbin-listing-depth branch from 74312cf to 34426fe Compare July 9, 2021 07:07
@C0rby C0rby force-pushed the implement-trashbin-listing-depth branch from 4e8e011 to df9e206 Compare July 9, 2021 08:01
@C0rby
Copy link
Contributor Author

C0rby commented Jul 9, 2021

@C0rby a rebase would make it!

@labkode done. 👍

phil-davis
phil-davis approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - more scenarios removed from expected-failures.

@labkode labkode merged commit aad6c51 into cs3org:master Jul 9, 2021
@C0rby C0rby deleted the implement-trashbin-listing-depth branch July 9, 2021 09:31
thmour pushed a commit to thmour/reva that referenced this pull request Jul 12, 2021
Support trashbin sub paths in the recycle API (cs3org#1827)
c22adf6
@butonic butonic mentioned this pull request Jul 13, 2021
Merged
2 tasks
@micbar micbar mentioned this pull request Jul 13, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

@phil-davis phil-davis phil-davis approved these changes

@butonic butonic Awaiting requested review from butonic

@ishank011 ishank011 Awaiting requested review from ishank011

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @labkode @phil-davis