test: use empty array for ocs notifications api #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@pascalwengerter CI is happy, as soon as it gets approved by QA team I merge it. |
|
Ping @phil-davis |
|
Discussing the implemention of this with @refs right now, will update this as soon as we come to a conclusion |
phil-davis
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
That's fine to change. We currently skip the test scenarios that test the notifications behavior - see mentions of ~@notifications-app-required in .drone.star
If/when notifications start to be added/supported we can easily remove the skipping, and at that point some development effort will provide more than just an empty response.
ishank011
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1805
@pascalwengerter