Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shares storage provider for accessing shares in /home #1807

Closed
wants to merge 18 commits into from

Conversation

aduffeck
Copy link
Contributor

This PR implements a new storage provider which exposes all shares the user has access to.

When mounted to /home/Shares it makes the magic in the gateway code superfluous. See https://github.com/aduffeck/ocis/commits/sharestorageprovider for an example implementation of that scenario.

@update-docs
Copy link

update-docs bot commented Jun 22, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck force-pushed the sharestorageprovider branch from af726b4 to ae3905f Compare June 22, 2021 08:14
@aduffeck aduffeck force-pushed the sharestorageprovider branch from ae3905f to 5c44e80 Compare June 22, 2021 08:21
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2021

This pull request introduces 1 alert when merging 5c44e80 into 567ec47 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2021

This pull request introduces 1 alert when merging 2c2e719 into df52c78 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2021

This pull request introduces 1 alert when merging f447a77 into df52c78 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@ishank011
Copy link
Contributor

@aduffeck @butonic would it also be a good idea to move the shares directory out to its separate mount instead of restricting it inside the home directory in this PR as well? I started on that in #1584. The tests fail because in ocdav, we prepend /home to all incoming requests including /Shares/..., so such requests would need to be handled.

@aduffeck
Copy link
Contributor Author

@ishank011 that is exactly what we are currently doing in #1846 (which kinda supersedes this pr, so I will close this one now). The shares are currently mounted to /home/Shares but it could be any other path as well.

@aduffeck aduffeck closed this Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants