-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build static binaries for Docker, so that we can use 'scratch' image #1766
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There could be dragons, see owncloud/ocis#375 |
@SamuAlfageme can you take a look? |
I'm trying this out in cs3org/ocm-test-suite#27. docker run -it --entrypoint /bin/sh revad fails because there is no |
@michielbdejong I totally empathize. Using the binary I have used this scratch-debugger script in the past. But if you're developing locally, I'll recommend you create an image with your OS of choice as base and then copying the revad binary In the future, things like ephemeral containers in k8s kubernetes/enhancements#277 will make that task easier. We can also reconsider using busybox or alpine if this becomes too annoying in the future |
@ylebre could you add a changelog entry for your fix? |
@SamuAlfageme sure thing, added to the PR now. |
@ylebre thx a bunch! |
…' image (cs3org#1766)" This partially reverts commit 07adb3f as there are a few issues when trying to run revad e.g. go-sqlite3 requires it: 2021-06-15 15:39:31.314 ERR go/src/github/cs3org/reva/cmd/revad/runtime/runtime.go:197 > error starting the http server error="http service dataprovider could not be started,: localfs: error initializing db: localfs: error preparing statement: Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub" pid=1
This should fix issue #1765