Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on the owncloudsql driver #1710

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Conversation

aduffeck
Copy link
Contributor

This PR adds a storage driver which connects to a oc10 storage backend (storage + database).

\cc @butonic

@update-docs
Copy link

update-docs bot commented May 17, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2021

This pull request introduces 1 alert when merging fc81af3 into 3387212 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@aduffeck aduffeck force-pushed the owncloudsql branch 2 times, most recently from 60b0e62 to 97a79eb Compare May 17, 2021 12:47
@butonic
Copy link
Contributor

butonic commented May 28, 2021

❤️

butonic
butonic previously approved these changes May 28, 2021
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start. add a changelog then we shouldy merge this asap. afterwards we can

  • combine it with a share manager for oc10
  • add a oc10 share storage provider

@aduffeck aduffeck marked this pull request as ready for review June 7, 2021 09:03
@aduffeck aduffeck requested a review from labkode as a code owner June 7, 2021 09:03
@butonic
Copy link
Contributor

butonic commented Jun 8, 2021

@labkode @ishank011 this is good to merge from my POV.

@ishank011 ishank011 merged commit 998ba22 into cs3org:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants