Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter shares based on type in OCS #1683

Merged
merged 3 commits into from
May 7, 2021
Merged

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested a review from labkode as a code owner May 5, 2021 12:38
@update-docs
Copy link

update-docs bot commented May 5, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ishank011 ishank011 force-pushed the share-type-ocs branch 2 times, most recently from 979fc66 to af118bb Compare May 5, 2021 12:54
@ishank011
Copy link
Contributor Author

@kulmann do we expect a list to be passed in the share_types query? Because the only usage I see is from the public links tab which sends /ocs/v2.php/apps/files_sharing//api/v1/shares?format=json&share_types=3

@kulmann
Copy link
Member

kulmann commented May 5, 2021

@ishank011 found this in oc10: https://github.com/owncloud/core/blob/799f107301e9835a46c3d1855f9a1a56f6706971/apps/files_sharing/js/sharedfilelist.js#L238 so it looks like it's supposed to be a comma separated list of share_types.

@ishank011
Copy link
Contributor Author

@kulmann perfect, thanks! Will change the code to handle this.

@labkode labkode merged commit 204c41b into cs3org:master May 7, 2021
@ishank011 ishank011 deleted the share-type-ocs branch May 7, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants