check ENOTDIR for readlink #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
remaining apiWebdavProperties1/copyFile.feature tests require returning a new error type that we can use to map the |
|
@ishank011 I also removed the failing test from eos because I don't expect it to be an issue for eos ... |
aduffeck
previously approved these changes
Mar 30, 2021
There was a problem hiding this comment.
LGTM 👍
You could maybe consider adding a unit test to the Describe("Child", ... block in node_test.go for it, e.g.
It("handles (broken) links including file segments by returning an non-existant node", func() {
child, err := parent.Child(env.Ctx, "file1/broken")
Expect(err).ToNot(HaveOccurred())
Expect(child).ToNot(BeNil())
Expect(child.Exists).To(BeFalse())
})
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
ishank011
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ "level": "error", "service": "storage", "pkg": "rgrpc", "traceid": "24d2f1bb7b3cb88c68fd005ced336cce", "error": "Decomposedfs: Wrap: readlink error: readlink /var/tmp/ocis/storage/users/nodes/a5066dc8-8566-4aa4-9286-d63c30bdc9a6/somename: not a directory", "time": "2021-03-29T19:01:05Z", "caller": "/home/vscode/go/pkg/mod/github.com/cs3org/[email protected]/internal/grpc/services/storageprovider/storageprovider.go:571", "message": "error stating: path:\"/home/testfile.txt/somename\" " }readlink returns ENOTDIR when a path segment is a file and not a directory.
os.IsNotExistwon't cover this case: golang/go#18974part of owncloud/ocis#1239
Links: https://www.man7.org/linux/man-pages/man2/readlink.2.html