Modularized api token management in GRAPPA drivers

[jimil749]

Fixes #1562

This PR moves duplicated api token management methods:

• renewAPIToken
• getAPIToken
• SendAPIRequest

into a seperate utils package to prevent duplication. The above methods are used by user/rest and group/rest packages.

PS: I am not 100% sure of the approach used here, so it'd be great if someone could suggest a better way to implement this. I'd be happy to work on the changes.

Signed-off-by: Jimil Desai [email protected]

[ishank011]

Let's try to remove any references to token generation in the interface methods. We can have a struct APITokenManager, which can be instantiated by the rest packages with all the necessary config. It can have one exported method SendAPIGetRequest which takes a URL and performs a GET to that.

[jimil749]

Let's try to remove any references to token generation in the interface methods. We can have a struct APITokenManager, which can be instantiated by the rest packages with all the necessary config. It can have one exported method SendAPIGetRequest which takes a URL and performs a GET to that.

@ishank011 can you explain a bit about the "instantiated by the rest packages" part?

Also, are you implying that the interface methods in user and group rest packages should call SendAPIGetRequest providing just the URL (instead of all the variables that I'm passing now)?

[jimil749]

Ah okay, so I should create a new struct in the utils package, namely APITokenManager, which would be initialized in the user and group rest packages and then call the SendAPIGetRequest method. Yes, that seems to make sense! 😅

And the fields for the struct should be the configurations, necessary for the token generation.

[jimil749]

@ishank011 Can you take a look?

[ishank011]

LGTM!

[ishank011]

@jimil749 grant_type :D

[jimil749]

Ah! My bad! I'll send a new pr with the change

[ishank011]

No worries, I fixed it in my PR