-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FindAcceptedUsers method to OCM Invite API #1527
Conversation
95b0c24
to
b0aa78e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ishank011, I think that this should be enough for what is needed here (atleast for 2)). It wouldn't exactly solve 1) (e-mail used for sending the invitation mail may be completely different from e-mails in accepted users model), but that shouldn't be much of a problem, given that the share originator always knows person's name AND e-mail or idp he used for accepting the invite. Only issue I could think of would be if the originator knows only a person's name and invite e-mail address, there could easily be multiple persons with the same name, even on the same idp, in his accepted users and it may not be easy to determine who is who. Maybe adding some timestamp when the invite token was accepted would help with this?
b0aa78e
to
56bca06
Compare
@mirekys I don't think the first case can be solved. Email is not the only way in which tokens are forwarded. So searching using that would fail in those cases. I don't see how timestamps would help. If multiple such users with the same name accept the same token, how would the original user know which one to pick? |
I was thinking that the original user approx. knows when he sent the invite to the person he wants to share something with. Timestamp could help him to eliminate people with the same name, that accepted his invites much earlier, and find the most recent accepted users faster (results could be sorted by that timestamp). It doesn't help much with the case of sending a bunch of invites to same-named people at the same time, but it's another factor that could help with searching through accepted invites. It's just a suggestion, I'm otherwise ok to go with what is already implemented in the PR 👍 |
@mirekys this is the current workflow. You can search for the user and then send a create share request using the results obtained. These steps will be merged in the UI. Please let me know your thoughts or if there are other workflows we can implement.
Depends on cs3org/cs3apis#111