Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate in EOS containers that TUS is not supported #1415

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Indicate in EOS containers that TUS is not supported #1415

merged 2 commits into from
Jan 21, 2021

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011
Copy link
Contributor Author

ishank011 commented Jan 21, 2021 •
edited
Loading

@phil-davis can you take a look what's happening here? https://drone.cernbox.cern.ch/cs3org/reva/264/10/6

@ishank011
Copy link
Contributor Author

Never mind. My bad

@ishank011 ishank011 marked this pull request as ready for review January 21, 2021 10:18
@ishank011 ishank011 requested a review from labkode as a code owner January 21, 2021 10:18
@ishank011 ishank011 requested review from butonic and refs January 21, 2021 10:18
butonic
butonic approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok it, it defaults to TUS being used and it has to be explicitly disabled. I don't know about all the implications for clients that still rely on the capabilities endpoint. but this is what will make ocis-web use normal PUT

@ishank011
Copy link
Contributor Author

Thanks a lot @butonic! For the capabilities endpoint, I already added the code to control the response using config envs in #1331

@ishank011 ishank011 merged commit 7fe671a into cs3org:master Jan 21, 2021
@ishank011 ishank011 deleted the eos-disable-tus branch January 21, 2021 14:44
@ishank011 ishank011 mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@labkode labkode Awaiting requested review from labkode

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishank011 @butonic