-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse HTTP Clients #1260
Reuse HTTP Clients #1260
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Thanks a lot for this @refs! I was looking at the storage provider tus methods for the leaks and was pulling my hair. This should be good! Can you fix the lint? We can merge it then |
haha, goland, too lazy to configure watchers :D on it |
@ishank011 imports should be good now. waiting for checks |
datagateway is also leaking ... @refs is adding it to this pr |
@ishank011 we should double check all places where the rhttp.GetHttpClient() is called. The context that is passed is not used anyway. So we can initialize the client when starting the services. That will allow reusing connections 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butonic definitely. I'll get to fixing these next. Thanks!
File descriptors on the ocdav service, especially on the put handler was leaking http connections. This PR addresses this.