Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check current node when iterating over path segments #1255

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Check current node when iterating over path segments #1255

merged 1 commit into from
Oct 19, 2020

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Oct 19, 2020 •
edited
Loading

When checking permissions we were always checking the leaf instead of using the current node while iterating over path segments.

@butonic butonic requested a review from labkode as a code owner October 19, 2020 11:41
C0rby
C0rby approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@butonic butonic requested a review from C0rby October 19, 2020 12:14
@butonic butonic added the bug Something isn't working label Oct 19, 2020
C0rby
C0rby approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@butonic butonic requested a review from ishank011 October 19, 2020 12:15
@ishank011 ishank011 merged commit e221f0b into cs3org:master Oct 19, 2020
@butonic butonic deleted the fix-permission-checks branch October 19, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@C0rby C0rby C0rby approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @C0rby @ishank011