Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a custom CodiMD mimetype #1233

Merged
merged 6 commits into from
Oct 8, 2020

Conversation

glpatcern
Copy link
Member

This is for now hardcoded, still have to parse the appropriate config section.

This is for now hardcoded, still have to parse the appropriate config section.
@glpatcern glpatcern requested a review from labkode as a code owner October 8, 2020 08:18
@update-docs
Copy link

update-docs bot commented Oct 8, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@glpatcern glpatcern requested review from ishank011 and removed request for labkode October 8, 2020 08:18
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glpatcern can we instead call RegisterMime from the init method of appprovider? Something like adding mime.RegisterMime(".zmd", "application/compressed-markdown") in

func init() {
rgrpc.Register("appprovider", New)
}

@glpatcern
Copy link
Member Author

Makes sense - and surely we can read the config there in appprovider once it's ready.

@ishank011
Copy link
Contributor

Well if we can add it through appprovider, the whole process becomes much simpler 😁

I'd still like to implement the functionality to pass configs to packages, but that can be put on the backburner for now. I'll create a PR to this branch to enable reading this config.

@glpatcern glpatcern changed the title WIP: add support for a custom CodiMD mimetype Add support for a custom CodiMD mimetype Oct 8, 2020
@glpatcern
Copy link
Member Author

Yes, I agree that passing configs to packages should be done as a back-burner task.

At the same time, with this PR we're saying "new mime types can be defined in the context of the appprovider only", which is fair enough for now but in general that statement could be proven wrong.

@ishank011 ishank011 merged commit 3645f8b into cs3org:master Oct 8, 2020
@ishank011
Copy link
Contributor

@glpatcern agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants