Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for invalid references #1216

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested a review from labkode as a code owner October 2, 2020 12:36
@ishank011
Copy link
Contributor Author

@phil-davis this change seems to have fixed a test which was expected to fail https://cloud.drone.io/cs3org/reva/2694/8/7. It just handles the case of listing the shares folder when share references might no longer exist, maybe because they were deleted.

@phil-davis
Copy link
Contributor

@ishank011 @labkode when the code i improved and more test scenarios pass, that is "a good thing" (tm).
Just remove the now-passing scenarios from the expected-failures file(s).
That will get the CI green, and we have a record of exactly which scenarios are failing at each PR, and we easily if a code change has a regression (more failing scenarios) or improves things (previously-failing scenarios now pass).

See PR #1217 - that will make CI green again.

@ishank011 ishank011 deleted the ref-errors branch October 9, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants