Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ocis move #1177

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix ocis move #1177

merged 1 commit into from
Sep 17, 2020

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 17, 2020

When renaming a file we updating the name attribute on the wrong node, causing the path construction to use the wrong name. This fixes the litmus move_coll test.

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ishank011 ishank011 merged commit 345aaf8 into cs3org:master Sep 17, 2020
@phil-davis
Copy link
Contributor

phil-davis commented Sep 17, 2020

@butonic #1166 (comment)

After this change, there are various prop* litmus tests failing on ocis storage.

I raised issue #1178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants