Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward OpenFileInAppProvider calls for OCM shares to remote reva #1140

Merged
merged 10 commits into from
Sep 18, 2020

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Sep 3, 2020

Also closes #1032

glpatcern
glpatcern previously approved these changes Sep 3, 2020
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I guess the gateway's Stat will take care of all that is needed (including forwarding remote errors that will be embedded in the OpenFileInAppProviderResponse).

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this one looks good

@ishank011 ishank011 changed the title Call the gateway stat method from appprovider Forward OpenFileInAppProvider calls for OCM shares to remote reva Sep 7, 2020
@ishank011 ishank011 marked this pull request as ready for review September 8, 2020 09:27
Copy link
Contributor

@SamuAlfageme SamuAlfageme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing this, we've seen that the 'username' encoded on the JWT token that gets forwarded to the WOPI Server (via Collabora) is the same for both the issuer and the receiver of the share:

{
   "typ":"JWT",
   "alg":"HS256"
}{
   "userid":"...",
   "filename":"/reva/daniel/test4/test.odt",
   "username":"daniel",
   "viewmode":"VIEW_MODE_READ_WRITE",
   "folderurl":"undefined",
   "exp":1599906112,
 }

Therefore, it renders the same username for both parties during a collaborative editing session. cc/ @glpatcern

@ishank011
Copy link
Contributor Author

Can't do that with the current implementation. We're passing the same token around as the original user and can't make changes to it as we don't know the jwt secret of the other site. This won't be an issue in the public shares implementation so I think we can leave it be.

@labkode labkode self-requested a review September 18, 2020 08:29
@labkode labkode merged commit d9ace48 into cs3org:master Sep 18, 2020
@ishank011 ishank011 deleted the appprovider-stat branch October 8, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Riva overwrite content directory
4 participants