-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward OpenFileInAppProvider calls for OCM shares to remote reva #1140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I guess the gateway's Stat
will take care of all that is needed (including forwarding remote errors that will be embedded in the OpenFileInAppProviderResponse
).
645dd83
to
6cfe5a9
Compare
7d9df99
to
cb6544d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this one looks good
302050f
to
dd89360
Compare
e346362
to
a8451bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing this, we've seen that the 'username' encoded on the JWT token that gets forwarded to the WOPI Server (via Collabora) is the same for both the issuer and the receiver of the share:
{
"typ":"JWT",
"alg":"HS256"
}{
"userid":"...",
"filename":"/reva/daniel/test4/test.odt",
"username":"daniel",
"viewmode":"VIEW_MODE_READ_WRITE",
"folderurl":"undefined",
"exp":1599906112,
}
Therefore, it renders the same username for both parties during a collaborative editing session. cc/ @glpatcern
Can't do that with the current implementation. We're passing the same token around as the original user and can't make changes to it as we don't know the jwt secret of the other site. This won't be an issue in the public shares implementation so I think we can leave it be. |
43ec834
to
5291970
Compare
Also closes #1032