Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add api trashbin tests #1123

Merged
merged 4 commits into from
Aug 27, 2020
Merged

[Tests-Only] Add api trashbin tests #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5645ce
[Tests-Only] Add api trashbin tests
phil-davis Aug 26, 2020
65b9757
Add TrashbinContext to local acceptance tests
phil-davis Aug 26, 2020
cfbd2d1
Adjust local trashbin scenarios now that new DAV path works
phil-davis Aug 26, 2020
f24b74d
Also use new dav-path for empty-trashbin local scenarios
phil-davis Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/acceptance/config/behat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ default:
- FavoritesContext:
- FilesVersionsContext:
- PublicWebDavContext:
- TrashbinContext:
- WebDavPropertiesContext:

extensions:
Expand Down
6 changes: 6 additions & 0 deletions tests/acceptance/expected-failures-on-OC-storage.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,8 @@ apiSharePublicLink2/uploadToPublicLinkShare.feature:255
# https://github.com/owncloud/ocis-reva/issues/286 Upload-only shares must not overwrite but create a separate file
apiSharePublicLink2/uploadToPublicLinkShare.feature:273
#
# https://github.com/owncloud/product/issues/179 Propfind to trashbin endpoint requires UUID
# https://github.com/owncloud/product/issues/178 File deletion using dav gives unique string in filename in the trashbin
apiTrashbin/trashbinDelete.feature:31
apiTrashbin/trashbinDelete.feature:32
apiTrashbin/trashbinDelete.feature:33
Expand All @@ -476,6 +478,8 @@ apiTrashbin/trashbinDelete.feature:37
apiTrashbin/trashbinDelete.feature:50
apiTrashbin/trashbinDelete.feature:67
#
# https://github.com/owncloud/product/issues/179 Propfind to trashbin endpoint requires UUID
# https://github.com/owncloud/product/issues/178 File deletion using dav gives unique string in filename in the trashbin
apiTrashbin/trashbinFilesFolders.feature:44
apiTrashbin/trashbinFilesFolders.feature:45
apiTrashbin/trashbinFilesFolders.feature:60
Expand All @@ -497,6 +501,8 @@ apiTrashbin/trashbinFilesFolders.feature:242
apiTrashbin/trashbinFilesFolders.feature:255
apiTrashbin/trashbinFilesFolders.feature:256
#
# https://github.com/owncloud/product/issues/179 Propfind to trashbin endpoint requires UUID
# https://github.com/owncloud/product/issues/178 File deletion using dav gives unique string in filename in the trashbin
apiTrashbin/trashbinRestore.feature:31
apiTrashbin/trashbinRestore.feature:32
apiTrashbin/trashbinRestore.feature:62
Expand Down
53 changes: 53 additions & 0 deletions tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinDelete.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
@api @files_trashbin-app-required
Feature: files and folders can be deleted from the trashbin
As a user
I want to delete files and folders from the trashbin
So that I can control my trashbin space and which files are kept in that space

Background:
Given user "Alice" has been created with default attributes and without skeleton files
And user "Alice" has uploaded file with content "to delete" to "/textfile0.txt"
And user "Alice" has uploaded file with content "to delete" to "/textfile1.txt"
And user "Alice" has created folder "PARENT"
And user "Alice" has created folder "PARENT/CHILD"
And user "Alice" has uploaded file with content "to delete" to "/PARENT/parent.txt"
And user "Alice" has uploaded file with content "to delete" to "/PARENT/CHILD/child.txt"

@smokeTest
@issue-product-139
@issue-product-178
@issue-product-179
Scenario Outline: Trashbin cannot be emptied
# after fixing all issues delete this Scenario and use the one from oC10 core
Given user "Alice" has uploaded file with content "file with comma" to "sample,0.txt"
And user "Alice" has uploaded file with content "file with comma" to "sample,1.txt"
And using <dav-path> DAV path
And user "Alice" has deleted file "<filename1>"
And user "Alice" has deleted file "<filename2>"
And as "Alice" file "<filename1>" should exist in the trashbin
And as "Alice" file "<filename2>" should exist in the trashbin
When user "Alice" empties the trashbin using the trashbin API
Then as "Alice" the file with original path "<filename1>" should exist in the trashbin
And as "Alice" the file with original path "<filename2>" should exist in the trashbin
Examples:
| dav-path | filename1 | filename2 |
| old | textfile0.txt | textfile1.txt |
| old | sample,0.txt | sample,1.txt |
| new | textfile0.txt | textfile1.txt |
| new | sample,0.txt | sample,1.txt |

@smokeTest
@issue-ocis-reva-118
@issue-product-179
# after fixing all issues delete this Scenario and use the one from oC10 core
Scenario: delete a single file from the trashbin
Given user "Alice" has deleted file "/textfile0.txt"
And user "Alice" has deleted file "/textfile1.txt"
And user "Alice" has deleted file "/PARENT/parent.txt"
And user "Alice" has deleted file "/PARENT/CHILD/child.txt"
When user "Alice" deletes the file with original path "textfile1.txt" from the trashbin using the trashbin API
Then the HTTP status code should be "405"
And as "Alice" the file with original path "/textfile1.txt" should exist in the trashbin
But as "Alice" the file with original path "/textfile0.txt" should exist in the trashbin
And as "Alice" the file with original path "/PARENT/parent.txt" should exist in the trashbin
And as "Alice" the file with original path "/PARENT/CHILD/child.txt" should exist in the trashbin
36 changes: 36 additions & 0 deletions tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinFilesFolders.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
@api @files_trashbin-app-required
Feature: files and folders exist in the trashbin after being deleted
As a user
I want deleted files and folders to be available in the trashbin
So that I can recover data easily

Background:
Given user "Alice" has been created with default attributes and skeleton files

@smokeTest
@issue-product-178
# after fixing all issues delete this Scenario and use the one from oC10 core
Scenario: deleting a file moves it to trashbin
Given using old DAV path
When user "Alice" deletes file "/textfile0.txt" using the WebDAV API
And using new DAV path
When user "Alice" deletes file "/textfile1.txt" using the WebDAV API
Then as "Alice" the file with original path "/textfile0.txt" should exist in the trashbin
And as "Alice" the file with original path "/textfile1.txt" should exist in the trashbin
And as "Alice" file "/textfile0.txt" should not exist
And as "Alice" file "/textfile1.txt" should not exist

@smokeTest
@issue-product-178
# after fixing all issues delete this Scenario and use the one from oC10 core
Scenario: deleting a folder moves it to trashbin
Given user "Alice" has created folder "/tmp1"
And user "Alice" has created folder "/tmp2"
And using old DAV path
When user "Alice" deletes folder "/tmp1" using the WebDAV API
And using new DAV path
When user "Alice" deletes folder "/tmp2" using the WebDAV API
Then as "Alice" the folder with original path "/tmp1" should exist in the trashbin
And as "Alice" the folder with original path "/tmp2" should exist in the trashbin
And as "Alice" folder "/tmp1" should not exist
And as "Alice" folder "/tmp2" should not exist