-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The system info metrics now use OpenCensus #1114
Conversation
Merge upstream
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
The system info metrics were also moved out of the Prometheus HTTP service. This can be merged now I think. |
pkg/sysinfo/metrics.go
Outdated
|
||
type sysInfoMetricsLabels = map[tag.Key]string | ||
|
||
type sysInfoMetrics struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the struct and the global variable? Let's just get the labels and register them.
Also, please fix the changelog |
Done and done. |
As discussed in #1105 and #1070, the system info metrics are now exposed via OpenCensus instead of the Prometheus client library.