Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The system info metrics now use OpenCensus #1114

Merged
merged 6 commits into from
Aug 25, 2020
Merged

The system info metrics now use OpenCensus #1114

merged 6 commits into from
Aug 25, 2020

Conversation

Daniel-WWU-IT
Copy link
Contributor

@Daniel-WWU-IT Daniel-WWU-IT commented Aug 21, 2020

As discussed in #1105 and #1070, the system info metrics are now exposed via OpenCensus instead of the Prometheus client library.

@Daniel-WWU-IT Daniel-WWU-IT requested a review from labkode as a code owner August 21, 2020 10:45
@update-docs
Copy link

update-docs bot commented Aug 21, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@Daniel-WWU-IT Daniel-WWU-IT changed the title [WIP] The system info metrics now use OpenCensus The system info metrics now use OpenCensus Aug 21, 2020
@Daniel-WWU-IT
Copy link
Contributor Author

The system info metrics were also moved out of the Prometheus HTTP service. This can be merged now I think.


type sysInfoMetricsLabels = map[tag.Key]string

type sysInfoMetrics struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the struct and the global variable? Let's just get the labels and register them.

@ishank011
Copy link
Contributor

Also, please fix the changelog

@Daniel-WWU-IT
Copy link
Contributor Author

Done and done.

@ishank011 ishank011 merged commit 0808d01 into cs3org:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants