Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC tests #1048

Merged
merged 2 commits into from
Aug 5, 2020
Merged

GRPC tests #1048

merged 2 commits into from
Aug 5, 2020

Conversation

individual-it
Copy link
Contributor

POC for GRPC tests including demonstration of TDD

This PR contains tests for the GetUser function. The same set of tests are run for the json and the demo provider.

The tests start the service by using the corresponding .toml file and then run the tests. As the different providers suppose to react the same way and happen to have the same users, the tests can be reused. To demonstrate small differences in the user table the idp of the json provider is set to a different value to the demo provider and this difference is handled in the test code.

Last this PR also fixes #1047

@individual-it individual-it requested a review from labkode as a code owner August 4, 2020 06:18
@individual-it individual-it marked this pull request as draft August 4, 2020 06:40
@individual-it individual-it marked this pull request as ready for review August 4, 2020 09:04
@labkode labkode merged commit fc44548 into cs3org:master Aug 5, 2020
@individual-it individual-it deleted the grpctests branch August 11, 2020 04:10
@butonic butonic mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

demo userpovider does not check the idp when getting a user
2 participants