Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a system information HTTP service #1037

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Added a system information HTTP service #1037

merged 3 commits into from
Aug 5, 2020

Conversation

Daniel-WWU-IT
Copy link
Contributor

The new service exposes system information via an HTTP endpoint. This currently only includes Reva version information (which isn't working atm in Reva's build system as it seems). The information are exposed in the form of Prometheus metrics so that we will be able to gather these in a streamlined way with some Mentix extensions yet to come.

@Daniel-WWU-IT Daniel-WWU-IT requested a review from labkode as a code owner July 30, 2020 14:35
@update-docs
Copy link

update-docs bot commented Jul 30, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@labkode labkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job and sorry for late review.

#1060

@labkode labkode merged commit 0e0ea3f into cs3org:master Aug 5, 2020
@ishank011
Copy link
Contributor

Can we use the same exporter as we do for the prometheus HTTP service? That is a lot cleaner and since both of them are running similar services, it would be better to have them use the same packages.

@labkode @Daniel-WWU-IT

@Daniel-WWU-IT
Copy link
Contributor Author

Daniel-WWU-IT commented Aug 10, 2020

@ishank011 Are you referring to using the contrib.go.opencensus.io/exporter/prometheus package? No, I don't think so, as that package is just using the official Go client library (as I do) to expose its own metrics. It is not a library that can be used to expose custom metrics I believe, though I'm not entirely sure if you can't add custom metrics there as well. As said, it also uses the same Go library internally as I do.

Or are you referring to merging the two services and include the system info in the "main" metrics exported by Reva? I suppose that is possible, but it still would require using the Prometheus Go library directly anyway.

@labkode
Copy link
Member

labkode commented Aug 10, 2020

@ishank011 that is a very good point. I keep track of it here: #1070
I'll add it to the new sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants