ocfs: lookup user to render template properly #1033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
63 tasks
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
ocfs-lookup-userid
branch
from
d4ae2ec to
7b3be9c
Compare
|
@butonic I think for EOS should be similar, @ishank011 was working on that. In our case, we use usernames as unique Ids in the EOS layout, so probably we are not finding this problem. Our paths are /eos/user/p/peter and not /eos/user/u-u-i-d/ |
|
yes, you can get around a lot of problems when using the username as the userid. Unfortunately, we have too many cases where u username changed, so we need to solve this properly. The good thing is reva allows us to implment this properly! But it is some work, especially the testsuite needs to be tought a few tricks ... |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
ocfs-lookup-userid
branch
from
7b3be9c to
d4a46c5
Compare
two of the failures are related to versioning. this PR changes some path building so it is likely related: one is about accessing another users files, which might this PR might actually have fixed ... or at least improved ... or made less wrong ... |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
these three tests: pass for me locally when run on owncloud/ocis#409 which contains this reva PR here and other fixes. |
|
resent as separate PR #1052 as I'll need it to continue working |
|
@butonic @PVince81 I think one issue is that the files versions are not working correctly |
|
ok, I managed to setup a reva close enough to CI and the issue is reproducible locally (no OCIS involved) |
|
@individual-it I could not reproduce your issue. I've logged everything I can locally in getUser() and when running the test "tests/acceptance/features/apiVersions/fileVersions.feature:149" I always get a user in there. However what's strange is that I don't get Brian at all there, so getUser is never called with Brian. |
|
okay, seems I had troubles with Redis. now I get something similar: |
|
so even though the user provider (users service?) is running, it doesn't find its endpoint |
|
it looks like the client service is being resolved, endpoint being localhost:19000 but then the returned instance fails when calling also strange is that the IDP of Brian is "localhost:18000", unless that's the higher level service |
|
on the other hand I'm wondering whether having to do that user lookup is really what we want and maybe for Brian the code shouldn't reach the part that does the lookup at all. |
|
no, it looks correct. We're logged in as "Brian" since we're querying the versions, but we want to |
|
Maybe going straight to the pool for querying that user provider isn't the correct way. Maybe we should go through the gateway instead ? |
|
So this is another setting we're missing: https://github.com/owncloud/ocis-reva/pull/420/files#diff-6e8d2a450c60708713085d20c0ce273eR342 I've pushed it to my PR: #1052 |
|
closing in favor of #1052 which contains further iterations and fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the username is used to construct paths, which breaks when mounting the owncloud storage driver at /oc and then expecting paths that use the username like
/oc/einstein/footo work, because they will mismatch the path that is used from propagation which uses/oc/u-u-i-das the root, giving ainternal path outside rooterror like this:To fix this we need to lookup the user at the user provider. using the username as the opaqueid works when the ldap filter is configured to allow lookup by both eg:
(&(objectclass=posixAccount)(|(ownclouduuid={{.OpaqueId}})(cn={{.OpaqueId}})))An annoying thing is that this makes the storage driver depend on the user provider... I am using the
sharedconfpackage to make this default to the gateway.We can save the trip to the user provider if the currently logged in user happens to match the requested user.
@labkode the eos driver should do a similar thing eg when parsing back the acls into a user. I can look into that after fixing our update branch, because it requires a lot of attenrtion right now, because we need to fix the testsuite to deal with the userid / username split.