Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update github.com/golang-jwt/jwt to v5 #4952

Closed
butonic opened this issue Nov 18, 2024 · 1 comment
Closed

update github.com/golang-jwt/jwt to v5 #4952

butonic opened this issue Nov 18, 2024 · 1 comment
Assignees
@rhafer

Comments

@butonic
Copy link
Contributor

butonic commented Nov 18, 2024 •
edited
Loading

https://github.com/golang-jwt/jwt has a migration guide how to update to v5.

It brings a Leeway Option that helps to deal with clock skew errors:

var v = jwt.NewValidator(jwt.WithLeeway(5*time.Second))
v.Validate(myClaims)
@butonic butonic moved this to Prio 3 or less in Infinite Scale Team Board Nov 18, 2024
@rhafer rhafer self-assigned this Nov 18, 2024
rhafer added a commit to rhafer/reva that referenced this issue Nov 18, 2024
@rhafer
Allow leeway for timestamps in reva tokens
96f5a9e 
This bumps golang-jwt/jwt to v5 and uses the new leeway feature to
allow for some clock skew between the reva service, which might be
running on different machines.

Fixes: cs3org#4952
@rhafer rhafer mentioned this issue Nov 18, 2024
Merged
rhafer added a commit to rhafer/reva that referenced this issue Nov 18, 2024
@rhafer
Allow leeway for timestamps in reva tokens
df25b97 
This bumps golang-jwt/jwt to v5 and uses the new leeway feature to
allow for some clock skew between the reva service, which might be
running on different machines.

Fixes: cs3org#4952
rhafer added a commit to rhafer/reva that referenced this issue Nov 18, 2024
@rhafer
Allow leeway for timestamps in reva tokens
9930379 
This bumps golang-jwt/jwt to v5 and uses the new leeway feature to
allow for some clock skew between the reva service, which might be
running on different machines.

Fixes: cs3org#4952
rhafer added a commit to rhafer/reva that referenced this issue Nov 19, 2024
@rhafer
Allow leeway for timestamps in reva tokens
fba9ac7 
This bumps golang-jwt/jwt to v5 and uses the new leeway feature to
allow for some clock skew between the reva service, which might be
running on different machines.

Fixes: cs3org#4952
rhafer added a commit that referenced this issue Nov 19, 2024
@rhafer
Allow leeway for timestamps in reva tokens
1373e6e 
This bumps golang-jwt/jwt to v5 and uses the new leeway feature to
allow for some clock skew between the reva service, which might be
running on different machines.

Fixes: #4952
@rhafer
Copy link
Contributor

rhafer commented Nov 19, 2024

Fix was merged

@rhafer rhafer closed this as completed Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhafer @butonic