Handle missing corner case

cs3org · Jun 19, 2023 · f3b4dc1 · f3b4dc1
1 parent 4e1cf9b
commit f3b4dc1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/pkg/storage/utils/decomposedfs/mtimesyncedcache/mtimesyncedcache.go b/pkg/storage/utils/decomposedfs/mtimesyncedcache/mtimesyncedcache.go
@@ -30,9 +30,13 @@ func (c *Cache[K, T]) Store(key K, mtime time.Time, value T) error {
 	return nil
 }
 
-func (c *Cache[K, T]) Load(key K) T {
-	entry, _ := c.entries.Load(key)
-	return entry.value
+func (c *Cache[K, T]) Load(key K) (T, bool) {
+	entry, ok := c.entries.Load(key)
+	if !ok {
+		var t T
+		return t, false
+	}
+	return entry.value, true
 }
 
 func (c *Cache[K, T]) LoadOrStore(key K, mtime time.Time, f func() (T, error)) (T, error) {

diff --git a/pkg/storage/utils/decomposedfs/mtimesyncedcache/mtimesyncedcache_test.go b/pkg/storage/utils/decomposedfs/mtimesyncedcache/mtimesyncedcache_test.go
@@ -29,22 +29,21 @@ var _ = Describe("Mtimesyncedcache", func() {
 			err := cache.Store(key, time, value)
 			Expect(err).ToNot(HaveOccurred())
 		})
-
-		PIt("returns an error when the mtime is older")
 	})
 
 	Describe("Load", func() {
 		It("loads the stored value", func() {
 			err := cache.Store(key, time.Now(), value)
 			Expect(err).ToNot(HaveOccurred())
 
-			v := cache.Load(key)
+			v, ok := cache.Load(key)
+			Expect(ok).To(BeTrue())
 			Expect(v).To(Equal(value))
 		})
 
-		PIt("fails the value doesn't exist", func() {
-			v := cache.Load(key)
-			Expect(v).To(Equal(value))
+		It("reports when the key doesn't exist", func() {
+			_, ok := cache.Load("doesnotexist")
+			Expect(ok).To(BeFalse())
 		})
 	})