Merge pull request #4954 from butonic/prevent-panic

prevent panic when logging error

changelog/unreleased/prevent-panic.md

@@ -0,0 +1,5 @@
+Bugfix: prevent a panic when logging an error
+
+We fixed a panic when constructing a path failed to get the parent for a node.
+
+https://github.com/cs3org/reva/pull/4954

pkg/storage/utils/decomposedfs/lookup/lookup.go

@@ -235,14 +235,17 @@ func (lu *Lookup) GenerateSpaceID(spaceType string, owner *user.User) (string, e
 // Path returns the path for node
 func (lu *Lookup) Path(ctx context.Context, n *node.Node, hasPermission node.PermissionFunc) (p string, err error) {
 	root := n.SpaceRoot
+	var child *node.Node
 	for n.ID != root.ID {
 		p = filepath.Join(n.Name, p)
+		child = n
 		if n, err = n.Parent(ctx); err != nil {
 			appctx.GetLogger(ctx).
 				Error().Err(err).
 				Str("path", p).
-				Str("spaceid", n.SpaceID).
-				Str("nodeid", n.ID).
+				Str("spaceid", child.SpaceID).
+				Str("nodeid", child.ID).
+				Str("parentid", child.ParentID).
 				Msg("Path()")
 			return
 		}