fix finish upload

pkg/rhttp/datatx/manager/simple/simple.go

@@ -89,6 +89,8 @@ func (m *manager) Handler(fs storage.FS) (http.Handler, error) {
 				w.WriteHeader(http.StatusForbidden)
 			case errtypes.InvalidCredentials:
 				w.WriteHeader(http.StatusUnauthorized)
+			case errtypes.InsufficientStorage:
+				w.WriteHeader(http.StatusInsufficientStorage)
 			default:
 				sublog.Error().Err(v).Msg("error uploading file")
 				w.WriteHeader(http.StatusInternalServerError)

pkg/storage/utils/decomposedfs/upload.go

@@ -423,6 +423,9 @@ func (upload *fileUpload) writeInfo() error {
 // FinishUpload finishes an upload and moves the file to the internal destination
 func (upload *fileUpload) FinishUpload(ctx context.Context) (err error) {
 
+	// ensure cleanup
+	defer upload.discardChunk()
+
 	fi, err := os.Stat(upload.binPath)
 	if err != nil {
 		appctx.GetLogger(upload.ctx).Err(err).Msg("Decomposedfs: could not stat uploaded file")
@@ -621,6 +624,12 @@ func (upload *fileUpload) discardChunk() {
 			return
 		}
 	}
+	if err := os.Remove(upload.infoPath); err != nil {
+		if !os.IsNotExist(err) {
+			appctx.GetLogger(upload.ctx).Err(err).Interface("info", upload.info).Str("infoPath", upload.infoPath).Interface("info", upload.info).Msg("Decomposedfs: could not discard chunk info")
+			return
+		}
+	}
 }
 
 // To implement the termination extension as specified in https://tus.io/protocols/resumable-upload.html#termination