cleanup toml config, add ocmd, drop gen subcommand (#2239)

.drone.star

@@ -571,7 +571,7 @@ def litmusOcisOldWebdav():
           "/drone/src/cmd/revad/revad -c frontend.toml &",
           "/drone/src/cmd/revad/revad -c gateway.toml &",
           "/drone/src/cmd/revad/revad -c storage-home-ocis.toml &",
-          "/drone/src/cmd/revad/revad -c storage-oc-ocis.toml &",
+          "/drone/src/cmd/revad/revad -c storage-users-ocis.toml &",
           "/drone/src/cmd/revad/revad -c users.toml",
         ],
       },
@@ -624,7 +624,7 @@ def litmusOcisNewWebdav():
           "/drone/src/cmd/revad/revad -c frontend.toml &",
           "/drone/src/cmd/revad/revad -c gateway.toml &",
           "/drone/src/cmd/revad/revad -c storage-home-ocis.toml &",
-          "/drone/src/cmd/revad/revad -c storage-oc-ocis.toml &",
+          "/drone/src/cmd/revad/revad -c storage-users-ocis.toml &",
           "/drone/src/cmd/revad/revad -c users.toml",
         ]
       },
@@ -678,7 +678,7 @@ def litmusOcisSpacesDav():
           "/drone/src/cmd/revad/revad -c frontend.toml &",
           "/drone/src/cmd/revad/revad -c gateway.toml &",
           "/drone/src/cmd/revad/revad -c storage-home-ocis.toml &",
-          "/drone/src/cmd/revad/revad -c storage-oc-ocis.toml &",
+          "/drone/src/cmd/revad/revad -c storage-users-ocis.toml &",
           "/drone/src/cmd/revad/revad -c users.toml",
         ]
       },
@@ -744,8 +744,8 @@ def ocisIntegrationTests(parallelRuns, skipExceptParts = []):
               "/drone/src/cmd/revad/revad -c gateway.toml &",
               "/drone/src/cmd/revad/revad -c shares.toml &",
               "/drone/src/cmd/revad/revad -c storage-home-ocis.toml &",
-              "/drone/src/cmd/revad/revad -c storage-oc-ocis.toml &",
-              "/drone/src/cmd/revad/revad -c storage-publiclink-ocis.toml &",
+              "/drone/src/cmd/revad/revad -c storage-users-ocis.toml &",
+              "/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
               "/drone/src/cmd/revad/revad -c ldap-users.toml",
             ],
           },
@@ -819,8 +819,8 @@ def s3ngIntegrationTests(parallelRuns, skipExceptParts = []):
               "/drone/src/cmd/revad/revad -c gateway.toml &",
               "/drone/src/cmd/revad/revad -c shares.toml &",
               "/drone/src/cmd/revad/revad -c storage-home-s3ng.toml &",
-              "/drone/src/cmd/revad/revad -c storage-oc-s3ng.toml &",
-              "/drone/src/cmd/revad/revad -c storage-publiclink-s3ng.toml &",
+              "/drone/src/cmd/revad/revad -c storage-users-s3ng.toml &",
+              "/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
               "/drone/src/cmd/revad/revad -c ldap-users.toml",
             ],
           },

changelog/unreleased/toml-cleanup.md

@@ -0,0 +1,5 @@
+Enhancement: update toml configs
+
+We updated the local and drone configurations, cleanad up the example configs and removed the reva gen subcommand which was generating outdated config.
+
+https://github.com/cs3org/reva/pull/2239

cmd/reva/completer.go

@@ -79,15 +79,7 @@ func (c *Completer) argumentCompleter(args ...string) []prompt.Suggest {
 		return []prompt.Suggest{}
 	}
 
-	var suggests []prompt.Suggest
-
 	switch args[0] {
-	case "gen":
-		suggests = convertCmdToSuggests([]*command{
-			genConfigSubCommand(),
-			genUsersSubCommand(),
-		})
-		return prompt.FilterHasPrefix(suggests, args[1], true)
 
 	case "login":
 		if len(args) == 2 {