Skip to content

Commit

Permalink
make jaeger-agent usable (#1379)
Browse files Browse the repository at this point in the history
  • Loading branch information
wkloucek authored Jan 5, 2021
1 parent e0ff57f commit 9a8de71
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
7 changes: 7 additions & 0 deletions changelog/unreleased/make-jaeger-agent-usable.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Make Jaeger agent usable

Previously, you could not use tracing with jaeger agent because the tracing connector is always used instead of the tracing endpoint.

This PR removes the defaults for collector and tracing endpoint.

https://github.com/cs3org/reva/pull/1379
8 changes: 0 additions & 8 deletions cmd/revad/runtime/runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,14 +263,6 @@ func setupOpenCensus(conf *coreConf) error {
return nil
}

if conf.TracingEndpoint == "" {
conf.TracingEndpoint = "localhost:6831"
}

if conf.TracingCollector == "" {
conf.TracingCollector = "http://localhost:14268/api/traces"
}

if conf.TracingServiceName == "" {
conf.TracingServiceName = "revad"
}
Expand Down

0 comments on commit 9a8de71

Please sign in to comment.