Disable cache (#3152)

* disable storage provider stat cache Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * only disable caching 404 Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * update changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * readd changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
cs3org · Aug 16, 2022 · 999fef2 · 999fef2
1 parent cafeda5
commit 999fef2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/disable-404-caching.md b/changelog/unreleased/disable-404-caching.md
@@ -0,0 +1,6 @@
+Bugfix: Disable caching of not found stat responses
+
+We no longer cache not found responses to prevent concurrent requests interfering with put requests.
+
+https://github.com/cs3org/reva/pull/3152
+https://github.com/owncloud/ocis/issues/4251
diff --git a/internal/grpc/services/gateway/storageprovidercache.go b/internal/grpc/services/gateway/storageprovidercache.go
@@ -270,7 +270,7 @@ func (c *cachedAPIClient) Stat(ctx context.Context, in *provider.StatRequest, op
 	switch {
 	case err != nil:
 		return nil, err
-	case resp.Status.Code != rpc.Code_CODE_OK && resp.Status.Code != rpc.Code_CODE_NOT_FOUND:
+	case resp.Status.Code != rpc.Code_CODE_OK:
 		return resp, nil
 	case key == "":
 		return resp, nil