Skip to content

Commit

Permalink
Disable versions on a storage provider (#4164)
Browse files Browse the repository at this point in the history
  • Loading branch information
gmgigi96 authored and S-Panta committed Sep 6, 2023
1 parent e26ffd8 commit 4810e38
Show file tree
Hide file tree
Showing 5 changed files with 82 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .drone.env
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The test runner source for API tests
APITESTS_COMMITID=9c3511d2b08de25b16be3d309d0a7710b6848747
APITESTS_COMMITID=5efc3c51a17e5c71a366436afeb52528ed49c7da
APITESTS_BRANCH=master
APITESTS_REPO_GIT_URL=https://github.com/owncloud/ocis.git
6 changes: 6 additions & 0 deletions changelog/unreleased/noversions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Disable versions on a storage provider

Added a GRPC interceptor that disable the versions
on a storage provider.

https://github.com/cs3org/reva/pull/4164
1 change: 1 addition & 0 deletions internal/grpc/interceptors/loader/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package loader
import (
// Load core GRPC services.
_ "github.com/cs3org/reva/internal/grpc/interceptors/eventsmiddleware"
_ "github.com/cs3org/reva/internal/grpc/interceptors/noversions"
_ "github.com/cs3org/reva/internal/grpc/interceptors/readonly"
// Add your own service here.
)
73 changes: 73 additions & 0 deletions internal/grpc/interceptors/noversions/noversions.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// Copyright 2018-2023 CERN
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// In applying this license, CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

package noversions

import (
"context"

provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
"github.com/cs3org/reva/pkg/rgrpc"
rstatus "github.com/cs3org/reva/pkg/rgrpc/status"
"google.golang.org/grpc"
)

const (
defaultPriority = 200
)

func init() {
rgrpc.RegisterUnaryInterceptor("noversions", NewUnary)
}

// NewUnary returns a new unary interceptor
// that checks grpc calls and blocks write requests.
func NewUnary(_ map[string]interface{}) (grpc.UnaryServerInterceptor, int, error) {
return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
switch req.(type) {
case *provider.ListContainerRequest:
resp, err := handler(ctx, req)
if listResp, ok := resp.(*provider.ListContainerResponse); ok && listResp.Infos != nil {
for _, info := range listResp.Infos {
if info.PermissionSet != nil {
info.PermissionSet.ListFileVersions = false
info.PermissionSet.RestoreFileVersion = false
}
}
}
return resp, err
case *provider.StatRequest:
resp, err := handler(ctx, req)
if statResp, ok := resp.(*provider.StatResponse); ok && statResp.Info != nil && statResp.Info.PermissionSet != nil {
statResp.Info.PermissionSet.ListFileVersions = false
statResp.Info.PermissionSet.RestoreFileVersion = false
}
return resp, err
case *provider.ListFileVersionsRequest:
return &provider.ListFileVersionsResponse{
Status: rstatus.NewPermissionDenied(ctx, nil, "permission denied: tried to list file versions on a no versions storage"),
}, nil
case *provider.RestoreFileVersionRequest:
return &provider.RestoreFileVersionResponse{
Status: rstatus.NewPermissionDenied(ctx, nil, "permission denied: tried to restore file version on a no versions storage"),
}, nil
default:
return handler(ctx, req)
}
}, defaultPriority, nil
}
2 changes: 1 addition & 1 deletion tests/ocis
Submodule ocis updated 118 files

0 comments on commit 4810e38

Please sign in to comment.