Async-cache a map copy for thread-safety reasons

cs3org · Jul 6, 2023 · 38d0c09 · 38d0c09
1 parent 9cbac03
commit 38d0c09
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/storage/utils/decomposedfs/metadata/messagepack_backend.go b/pkg/storage/utils/decomposedfs/metadata/messagepack_backend.go
@@ -257,7 +257,12 @@ func (b MessagePackBackend) loadAttributes(ctx context.Context, path string, sou
 		}
 	}
 
-	go func() { _ = b.metaCache.PushToCache(b.cacheKey(path), attribs) }()
+	// Prepare a copy to push to cache. Pushing the original map isn't thread-safe
+	attribsCopy := map[string][]byte{}
+	for k, v := range attribs {
+		attribsCopy[k] = v
+	}
+	go func() { _ = b.metaCache.PushToCache(b.cacheKey(path), attribsCopy) }()
 
 	return attribs, nil
 }