Skip to content

Commit

Permalink
Merge pull request #3078 from cs3org/release-2.7.0
Browse files Browse the repository at this point in the history
[build-deps] Release 2.7.0
  • Loading branch information
micbar authored Jul 15, 2022
2 parents 50902dd + 3da6e7c commit 0d02777
Show file tree
Hide file tree
Showing 22 changed files with 390 additions and 50 deletions.
2 changes: 1 addition & 1 deletion .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def lintStep():
"name": "lint",
"image": "registry.cern.ch/docker.io/golangci/golangci-lint:v1.42.1",
"commands": [
"golangci-lint run --timeout 3m0s",
"golangci-lint run --timeout 10m0s",
],
}

Expand Down
133 changes: 133 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,136 @@
Changelog for reva 2.7.0 (2022-07-15)
=======================================

The following sections list the changes in reva 2.7.0 relevant to
reva users. The changes are ordered by importance.

Summary
-------

* Fix #3075: Check permissions of the move operation destination
* Fix #3036: Fix revad with EOS docker image
* Fix #3037: Add uid- and gidNumber to LDAP queries
* Fix #4061: Forbid resharing with higher permissions
* Fix #3017: Removed unused gateway config "commit_share_to_storage_ref"
* Fix #3031: Return proper response code when detecting recursive copy/move operations
* Fix #3071: Make CS3 sharing drivers parse legacy resource id
* Fix #3035: Prevent cross space move
* Fix #3074: Send storage provider and space id to wopi server
* Fix #3022: Improve the sharing internals
* Fix #2977: Test valid filename on spaces tus upload
* Chg #3006: Use spaceID on the cs3api
* Enh #3043: Introduce LookupCtx for index interface
* Enh #3009: Prevent recursive copy/move operations
* Enh #2977: Skip space lookup on space propfind

Details
-------

* Bugfix #3075: Check permissions of the move operation destination

We now properly check the permissions on the target of move operations.

https://github.com/owncloud/ocis/issues/4192
https://github.com/cs3org/reva/pull/3075

* Bugfix #3036: Fix revad with EOS docker image

We've fixed the revad with EOS docker image. Previously the revad binary was build on Alpine and
not executable on the final RHEL based image.

https://github.com/cs3org/reva/issues/3036

* Bugfix #3037: Add uid- and gidNumber to LDAP queries

For the EOS storage to work correctly the uid- and gidNumber attributes need to be populated.

https://github.com/cs3org/reva/pull/3037

* Bugfix #4061: Forbid resharing with higher permissions

When creating a public link from a viewer share a user was able to set editor permissions on that
link. This was because of a missing check that is added now

https://github.com/owncloud/ocis/issues/4061
https://github.com/owncloud/ocis/issues/3881
https://github.com/owncloud/ocis/pull/4077

* Bugfix #3017: Removed unused gateway config "commit_share_to_storage_ref"

We've removed the unused gateway configuration option "commit_share_to_storage_ref".

https://github.com/cs3org/reva/pull/3017

* Bugfix #3031: Return proper response code when detecting recursive copy/move operations

We changed the ocdav response code to "409 - Conflict" when a recursive operation was detected.

https://github.com/cs3org/reva/pull/3031

* Bugfix #3071: Make CS3 sharing drivers parse legacy resource id

The CS3 public and user sharing drivers will now correct a resource id that is missing a spaceid
when it can split the storageid.

https://github.com/cs3org/reva/pull/3071

* Bugfix #3035: Prevent cross space move

Decomposedfs now prevents moving across space boundaries

https://github.com/cs3org/reva/pull/3035

* Bugfix #3074: Send storage provider and space id to wopi server

We are now concatenating storage provider id and space id into the endpoint that is sent to the
wopiserver

https://github.com/cs3org/reva/issues/3074

* Bugfix #3022: Improve the sharing internals

We cleaned up the sharing code validation and comparisons.

https://github.com/cs3org/reva/pull/3022

* Bugfix #2977: Test valid filename on spaces tus upload

Tus uploads in spaces now also test valid filenames.

https://github.com/owncloud/ocis/issues/3050
https://github.com/cs3org/reva/pull/2977

* Change #3006: Use spaceID on the cs3api

We introduced a new spaceID field on the cs3api to implement the spaces feature in a cleaner way.

https://github.com/cs3org/reva/pull/3006

* Enhancement #3043: Introduce LookupCtx for index interface

The index interface now has a new LookupCtx that can look up multiple values so we can more
efficiently look up multiple shares by id. It also takes a context so we can pass on the trace
context to the CS3 backend

https://github.com/cs3org/reva/pull/3043

* Enhancement #3009: Prevent recursive copy/move operations

We changed the ocs API to prevent copying or moving a folder into one of its children.

https://github.com/cs3org/reva/pull/3009

* Enhancement #2977: Skip space lookup on space propfind

We now construct the space id from the /dav/spaces URL intead of making a request to the
registry.

https://github.com/owncloud/ocis/issues/1277
https://github.com/owncloud/ocis/issues/2144
https://github.com/owncloud/ocis/issues/3073
https://github.com/cs3org/reva/pull/2977


Changelog for reva 2.6.1 (2022-06-27)
=======================================

Expand Down
2 changes: 1 addition & 1 deletion RELEASE_DATE
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2022-06-27
2022-07-15
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.6.1
2.7.0
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
141 changes: 103 additions & 38 deletions changelog/NOTE.md
Original file line number Diff line number Diff line change
@@ -1,68 +1,133 @@
Changelog for reva 2.6.1 (2022-06-27)
Changelog for reva 2.7.0 (2022-07-15)
=======================================

The following sections list the changes in reva 2.6.1 relevant to
The following sections list the changes in reva 2.7.0 relevant to
reva users. The changes are ordered by importance.

Summary
-------

* Fix #2998: Fix 0-byte-uploads
* Enh #3983: Add capability for alias links
* Enh #3000: Make less stat requests
* Enh #3003: Distinguish GRPC FAILED_PRECONDITION and ABORTED codes
* Enh #3005: Remove unused HomeMapping variable
* Fix #3075: Check permissions of the move operation destination
* Fix #3036: Fix revad with EOS docker image
* Fix #3037: Add uid- and gidNumber to LDAP queries
* Fix #4061: Forbid resharing with higher permissions
* Fix #3017: Removed unused gateway config "commit_share_to_storage_ref"
* Fix #3031: Return proper response code when detecting recursive copy/move operations
* Fix #3071: Make CS3 sharing drivers parse legacy resource id
* Fix #3035: Prevent cross space move
* Fix #3074: Send storage provider and space id to wopi server
* Fix #3022: Improve the sharing internals
* Fix #2977: Test valid filename on spaces tus upload
* Chg #3006: Use spaceID on the cs3api
* Enh #3043: Introduce LookupCtx for index interface
* Enh #3009: Prevent recursive copy/move operations
* Enh #2977: Skip space lookup on space propfind

Details
-------

* Bugfix #2998: Fix 0-byte-uploads
* Bugfix #3075: Check permissions of the move operation destination

We fixed a problem with 0-byte uploads by using TouchFile instead of going through TUS
(decomposedfs and owncloudsql storage drivers only for now).
We now properly check the permissions on the target of move operations.

https://github.com/cs3org/reva/pull/2998
https://github.com/owncloud/ocis/issues/4192
https://github.com/cs3org/reva/pull/3075

* Enhancement #3983: Add capability for alias links
* Bugfix #3036: Fix revad with EOS docker image

For better UX clients need a way to discover if alias links are supported by the server. We added a
capability under "files_sharing/public/alias"
We've fixed the revad with EOS docker image. Previously the revad binary was build on Alpine and
not executable on the final RHEL based image.

https://github.com/owncloud/ocis/issues/3983
https://github.com/cs3org/reva/pull/2991
https://github.com/cs3org/reva/issues/3036

* Enhancement #3000: Make less stat requests
* Bugfix #3037: Add uid- and gidNumber to LDAP queries

The /dav/spaces endpoint now constructs a reference instead of making a lookup grpc call,
reducing the number of requests.
For the EOS storage to work correctly the uid- and gidNumber attributes need to be populated.

https://github.com/cs3org/reva/pull/3000
https://github.com/cs3org/reva/pull/3037

* Enhancement #3003: Distinguish GRPC FAILED_PRECONDITION and ABORTED codes
* Bugfix #4061: Forbid resharing with higher permissions

Webdav distinguishes between 412 precondition failed for if match errors for locks or etags,
uses 405 Method Not Allowed when trying to MKCOL an already existing collection and 409
Conflict when intermediate collections are missing.
When creating a public link from a viewer share a user was able to set editor permissions on that
link. This was because of a missing check that is added now

The CS3 GRPC status codes are modeled after
https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto. When
trying to use the error codes to distinguish these cases on a storageprovider CreateDir call we
can map ALREADY_EXISTS to 405, FAILED_PRECONDITION to 409 and ABORTED to 412.
https://github.com/owncloud/ocis/issues/4061
https://github.com/owncloud/ocis/issues/3881
https://github.com/owncloud/ocis/pull/4077

Unfortunately, we currently use and map FAILED_PRECONDITION to 412. I assume, because the
naming is very similar to PreconditionFailed. However the GRPC docs are very clear that
ABORTED should be used, specifically mentioning etags and locks.
* Bugfix #3017: Removed unused gateway config "commit_share_to_storage_ref"

With this PR we internally clean up the usage in the decomposedfs and mapping in the ocdav
handler.
We've removed the unused gateway configuration option "commit_share_to_storage_ref".

https://github.com/cs3org/reva/pull/3003
https://github.com/cs3org/reva/pull/3010
https://github.com/cs3org/reva/pull/3017

* Enhancement #3005: Remove unused HomeMapping variable
* Bugfix #3031: Return proper response code when detecting recursive copy/move operations

We have removed the unused HomeMapping variable from the gateway.
We changed the ocdav response code to "409 - Conflict" when a recursive operation was detected.

https://github.com/cs3org/reva/pull/3005
https://github.com/cs3org/reva/pull/3031

* Bugfix #3071: Make CS3 sharing drivers parse legacy resource id

The CS3 public and user sharing drivers will now correct a resource id that is missing a spaceid
when it can split the storageid.

https://github.com/cs3org/reva/pull/3071

* Bugfix #3035: Prevent cross space move

Decomposedfs now prevents moving across space boundaries

https://github.com/cs3org/reva/pull/3035

* Bugfix #3074: Send storage provider and space id to wopi server

We are now concatenating storage provider id and space id into the endpoint that is sent to the
wopiserver

https://github.com/cs3org/reva/issues/3074

* Bugfix #3022: Improve the sharing internals

We cleaned up the sharing code validation and comparisons.

https://github.com/cs3org/reva/pull/3022

* Bugfix #2977: Test valid filename on spaces tus upload

Tus uploads in spaces now also test valid filenames.

https://github.com/owncloud/ocis/issues/3050
https://github.com/cs3org/reva/pull/2977

* Change #3006: Use spaceID on the cs3api

We introduced a new spaceID field on the cs3api to implement the spaces feature in a cleaner way.

https://github.com/cs3org/reva/pull/3006

* Enhancement #3043: Introduce LookupCtx for index interface

The index interface now has a new LookupCtx that can look up multiple values so we can more
efficiently look up multiple shares by id. It also takes a context so we can pass on the trace
context to the CS3 backend

https://github.com/cs3org/reva/pull/3043

* Enhancement #3009: Prevent recursive copy/move operations

We changed the ocs API to prevent copying or moving a folder into one of its children.

https://github.com/cs3org/reva/pull/3009

* Enhancement #2977: Skip space lookup on space propfind

We now construct the space id from the /dav/spaces URL intead of making a request to the
registry.

https://github.com/owncloud/ocis/issues/1277
https://github.com/owncloud/ocis/issues/2144
https://github.com/owncloud/ocis/issues/3073
https://github.com/cs3org/reva/pull/2977


Loading

0 comments on commit 0d02777

Please sign in to comment.