Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change in module datatx: PullTransfer -> CreateTransfer #195

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Name change in module datatx: PullTransfer -> CreateTransfer #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3bfed1
Name change in module datatx: PullTransfer -> CreateTransfer
antoonp Dec 12, 2022
513028d
Add share_id field to message CreateTransferRequest.
antoonp Jan 30, 2023
e78e1b5
Merge branch 'main' into create-transfer
glpatcern Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cs3/gateway/v1beta1/gateway_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ service GatewayAPI {
// ************************** FILE TRANSFER ************************/
// *****************************************************************/

// Requests the destination to pull a resource from source.
rpc PullTransfer(cs3.tx.v1beta1.PullTransferRequest) returns (cs3.tx.v1beta1.PullTransferResponse);
// Requests creation of a transfer.
rpc CreateTransfer(cs3.tx.v1beta1.CreateTransferRequest) returns (cs3.tx.v1beta1.CreateTransferResponse);
// Requests a transfer status.
rpc GetTransferStatus(cs3.tx.v1beta1.GetTransferStatusRequest) returns (cs3.tx.v1beta1.GetTransferStatusResponse);
// Requests to cancel a transfer.
Expand Down
15 changes: 9 additions & 6 deletions cs3/tx/v1beta1/tx_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ import "cs3/types/v1beta1/types.proto";
// Any method MAY return UNKNOWN.
// Any method MAY return UNAUTHENTICATED.
service TxAPI {
// Requests the destination to pull a resource from source.
// Returns a PullTransferResponse
rpc PullTransfer(PullTransferRequest) returns (PullTransferResponse);
// Requests creation of a transfer.
// Returns a CreateTransferResponse.
rpc CreateTransfer(CreateTransferRequest) returns (CreateTransferResponse);
// Requests a transfer status.
rpc GetTransferStatus(GetTransferStatusRequest) returns (GetTransferStatusResponse);
// Requests to cancel a transfer.
Expand All @@ -63,7 +63,7 @@ service TxAPI {
rpc RetryTransfer(RetryTransferRequest) returns (RetryTransferResponse);
}

message PullTransferRequest {
message CreateTransferRequest {
// REQUIRED.
// The source target URI. Should include at the minimum all the info needed to access the source.
// https://golang.org/pkg/net/url/#URL provides a quick view of the format.
Expand All @@ -72,12 +72,15 @@ message PullTransferRequest {
// The destination target URI. Should include at the minimum all the info needed to access the destination.
// https://golang.org/pkg/net/url/#URL provides a quick view of the format.
string dest_target_uri = 2;
// REQUIRED.
// The share Id of the share this transfer is based on.
cs3.sharing.ocm.v1beta1.ShareId share_id = 3;
// OPTIONAL.
// Opaque information.
cs3.types.v1beta1.Opaque opaque = 3;
cs3.types.v1beta1.Opaque opaque = 4;
}

message PullTransferResponse {
message CreateTransferResponse {
// REQUIRED.
// The response status.
cs3.rpc.v1beta1.Status status = 1;
Expand Down
Loading