-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional oldLock to RefreshLockRequest #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89edc94
to
c7cafee
Compare
glpatcern
reviewed
Sep 29, 2022
c7cafee
to
17f2c13
Compare
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Sep 29, 2022
glpatcern
approved these changes
Sep 29, 2022
17f2c13
to
ac44ed9
Compare
@glpatcern I have no merge privileges 😏 |
Just wanted to wait for the CI, then I'll merge! |
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Sep 30, 2022
…s#183 Correspondingly updated the test suite and the minimum CS3APIs version
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Sep 30, 2022
…s#183 Correspondingly updated the test suite and the minimum CS3APIs version
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Sep 30, 2022
…s#183 Correspondingly updated the test suite and the minimum CS3APIs version
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Oct 4, 2022
…s#183 Correspondingly updated the test suite and the minimum CS3APIs version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #182
We decided together with @glpatcern that the refreshLock operation can be extended to be used for an atomic
UnlockAndRelock
operation.