Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #173

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Performance improvements #173

merged 3 commits into from
Jun 20, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Jun 17, 2022

Description

Releated to cs3org/reva#2976
to improve the performance.

@labkode

Changes

@micbar micbar requested a review from labkode as a code owner June 17, 2022 07:53
@micbar micbar force-pushed the space-info-name branch from 3d58afc to 3d6d8e7 Compare June 17, 2022 08:05
@micbar micbar force-pushed the space-info-name branch from 82be121 to 176b636 Compare June 17, 2022 08:55
@micbar micbar changed the title add space and name to ResourceInfo Performance improvements Jun 17, 2022
@micbar
Copy link
Member Author

micbar commented Jun 17, 2022

@labkode All these changes should be non-breaking and apply to master and edge branches without code changes.

We plan to use the new properties in the edge branch for performance optimizations.

@micbar
Copy link
Member Author

micbar commented Jun 17, 2022

@glpatcern

@glpatcern glpatcern self-requested a review June 20, 2022 10:32
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic could you maybe provide an example how you'd use the field_mask for an ETAG-only query as mentioned in cs3org/reva#2976 ?

@micbar
Copy link
Member Author

micbar commented Jun 20, 2022

@glpatcern In general, a field mask uses a slice of strings.

like

FieldMask: &field_mask.FieldMask{Paths: []string{"etag"}},

@micbar
Copy link
Member Author

micbar commented Jun 20, 2022

@labkode Please merge this after approval. We have no merge powers in this repo.

@glpatcern glpatcern merged commit 47bde33 into cs3org:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants