Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default_application to MimeTypeInfo #157

Merged
merged 2 commits into from
Nov 4, 2021
Merged

add default_application to MimeTypeInfo #157

merged 2 commits into from
Nov 4, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 3, 2021 •
edited
Loading

needed by cs3org/reva#2230

@wkloucek wkloucek requested a review from labkode as a code owner November 3, 2021 10:00
@wkloucek wkloucek mentioned this pull request Nov 3, 2021
Merged
@glpatcern glpatcern self-requested a review November 3, 2021 11:57
glpatcern
glpatcern approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you please also apply the (unrelated) suggested change?

cs3/app/registry/v1beta1/resources.proto Outdated Show resolved Hide resolved
@glpatcern
Copy link
Member

Thanks Willy, I don't get why the build is failing though: could you perhaps try and make so all artifacts are regenerated?

@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 4, 2021

Thanks Willy, I don't get why the build is failing though: could you perhaps try and make so all artifacts are regenerated?

I already posted in the CS3apis Gitter channel about this. I think the changes fromhttps://github.com/cs3org/cs3apis-build/pull/18 broke it.

@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 4, 2021

@glpatcern CI is green now

@glpatcern glpatcern merged commit 9648574 into cs3org:main Nov 4, 2021
@wkloucek wkloucek deleted the default_application branch November 4, 2021 13:10
@gmgigi96 gmgigi96 mentioned this pull request Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @glpatcern