Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend app registry with methods to add providers and mimetype filters #131

Merged
merged 3 commits into from
Jul 26, 2021

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Jun 11, 2021

This PR adds methods to register new app providers on the fly and to set and retrieve default app providers for mime types. It has a change that might break the clients using the current version. We remove the mime type filters from ListAppProvidersRequest as that is redundant and performs the same functionality as GetAppProvidersRequest.

@ishank011 ishank011 requested review from labkode and glpatcern June 11, 2021 09:14
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: I see you simplified the filter for ListAppProvidersRequest, I had created it with the oneof form following the pattern of other similar requests, but if you think it's better like this I'm OK.

@labkode
Copy link
Member

labkode commented Jun 16, 2021

@ishank011 fix the proto lock conflict. Maybe you'll need to create a new proto lock file. Please document breaking changes.

@ishank011
Copy link
Contributor Author

@labkode done

@labkode labkode merged commit 05f37d3 into cs3org:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants