Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add status code 507 #115

Merged
merged 2 commits into from
Mar 24, 2021
Merged

add status code 507 #115

merged 2 commits into from
Mar 24, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 16, 2021

This PR adds the status code 507 Insufficient Storage to the CS3 apis. This status code is eg. needed for enforcing storage quotas.

Will be used by cs3org/reva#1557

@wkloucek wkloucek changed the title enforce quota add status code 507 Mar 22, 2021
@wkloucek wkloucek marked this pull request as ready for review March 22, 2021 10:51
@wkloucek wkloucek requested a review from labkode as a code owner March 22, 2021 10:51
Copy link
Member

@labkode labkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkloucek just put the comment before the definition of the new error like the other defs.

@wkloucek wkloucek requested a review from labkode March 22, 2021 12:57
@ishank011
Copy link
Contributor

@wkloucek I can merge this, but #116 has a breaking change which is implemented in reva by cs3org/reva#1570. I'll try to get this in this week but for the time being, you can rebase your change on top of this PR. Would that be fine?

@wkloucek
Copy link
Contributor Author

@ishank011 is rebased

@ishank011 ishank011 merged commit 4a26f4f into cs3org:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants