Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDP service chart #43

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add IDP service chart #43

wants to merge 4 commits into from

Conversation

mirekys
Copy link
Member

@mirekys mirekys commented Oct 19, 2022

Adds a deployment Chart of an OpenID Connect Identity Provider service, compatible with CS3 APIs, based on OCIS IDP implementation. This service is required to enable users to log in to 3rdparty services using their ScienceMesh accounts (sciencemesh/sciencemesh#176).

Contributing a Chart / update to an existing Chart

  • Run helm lint on the chart dir.
  • (Update) Bump the Chart.yaml version before merging, to release it as a new version.
  • (Update) If the PR includes new configurable parameters in the chart's values.yaml. Add documentation in the appropiate README.

@mirekys
Copy link
Member Author

mirekys commented Oct 20, 2022

The GH action helm/chart-testing-action version used for linting seems to be quite outdated (Jul 2020), using old helm version. The randBytes function used by the chart was introduced in helm at Dec 2020 https://github.com/Masterminds/sprig/blob/master/CHANGELOG.md#release-320-2020-12-14, would it be OK to update the GH action in workflow? @SamuAlfageme

@mirekys mirekys requested a review from SamuAlfageme October 21, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant