WOPI Bridge integration #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a fallback to http://<chart-name>:<svc-port> for non- defined ingress'. Also, remove hardcoded loglevel and enable its override.
SamuAlfageme
force-pushed
the
wopibridge_integration
branch
4 times, most recently
from
3f4b682 to
2652ea3
Compare
- Fix an issue with whitespace stripping on the 'wopiserver.url'
SamuAlfageme
force-pushed
the
wopibridge_integration
branch
from
2652ea3 to
f520052
Compare
... based on the ingress/service provided values, which sometimes is unaccurate (e.g. wildcard paths for the nginx ingress resources). Or when the operator does not want to rely on the chart-provided ingress but rather on its own. Add the config table for the WOPI bridge and use its url for the .Values.config.appProviders.codimdurl to prevent using CodiMD's Bump the wopiserver version to v5.4
SamuAlfageme
force-pushed
the
wopibridge_integration
branch
from
cae36a2 to
05eb576
Compare
glpatcern
approved these changes
Aug 27, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a simple wopibridge sidecar service to connect the WOPI Server to CodiMD and other office-like applications.
Additional features:
wopiurl/downloadurl- cc/ @Daniel-WWU-IT (closes Adjust hardcoded values on the wopiserver ConfigMap #15)--set config.logleveloption to Helm.Contributing a Chart / update to an existing Chart
helm linton the chart dir.Chart.yamlversion before merging, to release it as a new version.values.yaml. Add documentation in the appropiate README.