Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: configure canvas wrapper #5

Merged
merged 19 commits into from
Mar 6, 2024
Merged

Feat: configure canvas wrapper #5

merged 19 commits into from
Mar 6, 2024

Conversation

Zzz212zzZ
Copy link

  • Configure the LMS API wrapper.
  • Add a toy service (bcourses) to test the API wrapper.
  • Before we will intergrate Omniauth-canvas to get token, I used my dev_token for development test.
  • This token is stored in credentials.

Connor-Bernard
Connor-Bernard requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@Connor-Bernard Connor-Bernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you made a lot of new views, controllers, etc., but I don't see any testing for this.

app/helpers/bcourses_helper.rb Outdated Show resolved Hide resolved
@Zzz212zzZ Zzz212zzZ force-pushed the #187042260-configure-canvas-wrapper branch from 0c65aa0 to 681af7c Compare February 20, 2024 08:56
@Zzz212zzZ Zzz212zzZ force-pushed the #187042260-configure-canvas-wrapper branch from 99d9301 to 2034c1a Compare February 20, 2024 19:42
Connor-Bernard
Connor-Bernard requested changes Mar 1, 2024
View reviewed changes
app/controllers/bcourses_controller.rb Outdated Show resolved Hide resolved
app/controllers/bcourses_controller.rb Outdated Show resolved Hide resolved
Connor-Bernard
Connor-Bernard requested changes Mar 3, 2024
View reviewed changes
app/controllers/bcourses_controller.rb Outdated Show resolved Hide resolved
config/credentials.yml.enc Outdated Show resolved Hide resolved
Connor-Bernard
Connor-Bernard requested changes Mar 5, 2024
View reviewed changes
app/controllers/bcourses_controller.rb Outdated Show resolved Hide resolved
config/credentials.yml.enc Outdated Show resolved Hide resolved
config/credentials/production.yml.enc Outdated Show resolved Hide resolved
Connor-Bernard
Connor-Bernard approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Connor-Bernard Connor-Bernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzz212zzZ Zzz212zzZ merged commit 8c617fb into main Mar 6, 2024
3 checks passed
@Connor-Bernard Connor-Bernard deleted the #187042260-configure-canvas-wrapper branch March 8, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor-Bernard Connor-Bernard Connor-Bernard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zzz212zzZ @Connor-Bernard