Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add]: structure flow to create the assignment new [new pr] #43

Merged
merged 15 commits into from
Apr 28, 2024

Conversation

Zzz212zzZ
Copy link

General Info

Changes

Explain your changes here (in such a way that you would understand why you made them a year from now).

  1. Adjust the Assignment Table. Now it should rely on Course_to_lms Table instead of lms Table.
    image
  2. Implement the create method within the assignment controller

Testing

  • Validate if the parameters are not int.
  • The assignment can be created only when both the course and lms exist before. It uses a foreign key of course_to_lms_id to ensure this.
  • We also do not want to create a duplicated test, i.e., there shouldn't exist such a record that has the same course_to_lms_id and external_assignment_id that we want to create.

Documentation

Updated E-R diagram

Checklist

  • Name of branch corresponds to story

@Zzz212zzZ Zzz212zzZ marked this pull request as draft April 23, 2024 23:26
@Zzz212zzZ Zzz212zzZ changed the title 187434339 structure flow to create the assignment new [new pr] [Add]: structure flow to create the assignment new [new pr] Apr 23, 2024
@Zzz212zzZ Zzz212zzZ marked this pull request as ready for review April 23, 2024 23:40
Copy link
Member

@Connor-Bernard Connor-Bernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzz212zzZ Zzz212zzZ merged commit 6b89523 into main Apr 28, 2024
6 checks passed
@Connor-Bernard Connor-Bernard deleted the 187434339-structure-flow-to-create-the-assignment-new branch April 28, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants